-
Notifications
You must be signed in to change notification settings - Fork 11
docs(changelog): version 1.4.6 [citest skip] #159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Update changelog and .README.html for version 1.4.6 Signed-off-by: Rich Megginson <rmeggins@redhat.com>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates documentation to add the 1.4.6 release notes to the changelog, describing recent refactor and CI-related changes. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `CHANGELOG.md:7-10` </location>
<code_context>
+
+### Other Changes
+
+- refactor: handle INJECT_FACTS_AS_VARS=false by using ansible_facts instead (#157)
+- ci: use ANSIBLE_INJECT_FACT_VARS=false by default for testing (#158)
+
[1.4.5] - 2026-01-06
</code_context>
<issue_to_address>
**question (typo):** The two variable names differ (`INJECT_FACTS_AS_VARS` vs `ANSIBLE_INJECT_FACT_VARS`); please confirm this is intentional.
If they are intentionally different settings, consider briefly distinguishing them in the changelog; if not, this is likely a naming typo that should be corrected to avoid confusing users about which variable to use.
```suggestion
### Other Changes
- refactor: handle `INJECT_FACTS_AS_VARS=false` (collection option) by using `ansible_facts` instead (#157)
- ci: use `ANSIBLE_INJECT_FACT_VARS=false` (Ansible environment variable) by default for testing (#158)
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| ### Other Changes | ||
|
|
||
| - refactor: handle INJECT_FACTS_AS_VARS=false by using ansible_facts instead (#157) | ||
| - ci: use ANSIBLE_INJECT_FACT_VARS=false by default for testing (#158) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question (typo): The two variable names differ (INJECT_FACTS_AS_VARS vs ANSIBLE_INJECT_FACT_VARS); please confirm this is intentional.
If they are intentionally different settings, consider briefly distinguishing them in the changelog; if not, this is likely a naming typo that should be corrected to avoid confusing users about which variable to use.
| ### Other Changes | |
| - refactor: handle INJECT_FACTS_AS_VARS=false by using ansible_facts instead (#157) | |
| - ci: use ANSIBLE_INJECT_FACT_VARS=false by default for testing (#158) | |
| ### Other Changes | |
| - refactor: handle `INJECT_FACTS_AS_VARS=false` (collection option) by using `ansible_facts` instead (#157) | |
| - ci: use `ANSIBLE_INJECT_FACT_VARS=false` (Ansible environment variable) by default for testing (#158) |
Update changelog and .README.html for version 1.4.6
Signed-off-by: Rich Megginson rmeggins@redhat.com
Summary by Sourcery
Documentation: