Skip to content

Conversation

@richm
Copy link
Collaborator

@richm richm commented Jan 13, 2026

Ansible 2.20 has deprecated the use of Ansible facts as variables. For
example, ansible_distribution is now deprecated in favor of
ansible_facts["distribution"]. This is due to making the default
setting INJECT_FACTS_AS_VARS=false. For now, this will create WARNING
messages, but in Ansible 2.24 it will be an error.

In order to ensure that commits and PRs conform to this, use
ANSIBLE_INJECT_FACT_VARS=false by default in our CI testing.

Update README-ostree.md if needed.

See https://docs.ansible.com/projects/ansible/latest/porting_guides/porting_guide_core_2.20.html#inject-facts-as-vars

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Configure CI and test workflows to run Ansible with fact variables injection disabled and align documentation with the ansible_facts key style.

CI:

  • Set ANSIBLE_INJECT_FACT_VARS=false for qemu-kvm integration tests to enforce the non-injected facts behavior.
  • Pass SR_ANSIBLE_INJECT_FACT_VARS=false into TFT workflow runs to ensure consistent Ansible fact handling in tests.

Documentation:

  • Clarify README-ostree ansible_facts usage by switching to double-quoted dictionary key notation in examples.

Ansible 2.20 has deprecated the use of Ansible facts as variables.  For
example, `ansible_distribution` is now deprecated in favor of
`ansible_facts["distribution"]`.  This is due to making the default
setting `INJECT_FACTS_AS_VARS=false`.  For now, this will create WARNING
messages, but in Ansible 2.24 it will be an error.

In order to ensure that commits and PRs conform to this, use
ANSIBLE_INJECT_FACT_VARS=false by default in our CI testing.

Update README-ostree.md if needed.

See https://docs.ansible.com/projects/ansible/latest/porting_guides/porting_guide_core_2.20.html#inject-facts-as-vars

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
@richm richm self-assigned this Jan 13, 2026
@sourcery-ai
Copy link

sourcery-ai bot commented Jan 13, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Configures CI and test infrastructure to run Ansible with fact variable injection disabled by default, and updates documentation to use the non-deprecated ansible_facts key access syntax.

File-Level Changes

Change Details Files
Update README to reflect the preferred ansible_facts key access syntax with double quotes.
  • Change ansible_facts examples from single-quoted key access to double-quoted key access in documentation.
  • Ensure the documented DISTRO-VERSION examples still match the facts used by Ansible.
README-ostree.md
Ensure CI integration tests run with Ansible fact variable injection disabled by default.
  • Set ANSIBLE_INJECT_FACT_VARS environment variable to "false" in the qemu-kvm integration tests GitHub Actions workflow so test runs use the non-injected fact style.
  • Wire the new fact injection setting into the testing framework tooling variable SR_ANSIBLE_INJECT_FACT_VARS in the tft GitHub Actions workflow so downstream tests can honor the new default.
.github/workflows/qemu-kvm-integration-tests.yml
.github/workflows/tft.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@richm richm merged commit b9ac214 into main Jan 13, 2026
23 checks passed
@richm richm deleted the ci-inject-fact-vars branch January 13, 2026 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants