-
Notifications
You must be signed in to change notification settings - Fork 5
hpc: add variables for azure resources and tools #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideDefines standard Azure-specific HPC resource, tools, tests, and runtime directory variables under /opt/hpc/azure and /var/hpc/azure for consistent reuse in Ansible roles and playbooks. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spetrosi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the point of defining these variables without using them in the role? Do you plan to use them later? I am worried about some of them remaining unused.
vars/main.yml
Outdated
| __hpc_azure_tests_dir: "{{ __hpc_azure_resource_dir }}/tests" | ||
|
|
||
| # location for runtime selected azure resources | ||
| __hpc_azure_runtime_dir: "/var/hpc/azure" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| __hpc_azure_runtime_dir: "/var/hpc/azure" | |
| __hpc_azure_runtime_dir: /var/hpc/azure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I split them out of the sku customisation feature that uses them all, so Gaurav doesn't have to wait for me to finish the sku customisation feature to be able to update the monitoring tool installation to use these locations. See dgchinner@0620b94 for the WIP changes.
Define the directory hierarchy for cloud specific tools, scripts resources and tests and encode them into variables for common usage. The structure we want to use for static files follows this template: /opt/hpc/<cloud-vendor>/bin/ # one-off binaries and scripts /opt/hpc/<cloud-vendor>/lib/... # resources and libraries /opt/hpc/<cloud-vendor>/tools/... # standalone tools /opt/hpc/<cloud-vendor>/tests/ # test scripts for local/CI testing For runtime files (e.g. configuration files set up by boot services), we will store them in: /var/hpc/<cloud-vendor>/.... These common directories will be defined by the following set of variables: __hpc_<cloud>_resource_dir # /opt/hpc/<cloud-vendor>/ __hpc_<cloud>_tools_dir # /opt/hpc/<cloud-vendor>/tools/ __hpc_<cloud>_tests_dir # /opt/hpc/<cloud-vendor>/tests/ __hpc_<cloud>_runtime_dir # /var/hpc/<cloud-vendor>/ At the moment we only support Azure, so only those variables are defined. Signed-off-by: Dave Chinner <dchinner@redhat.com>
96eb110 to
54a6c88
Compare
|
Sorry, screwed up a test branch push and it landed here, I've reverted the azure-dirs branch back to 54a6c88 where it should be for this PR. |
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Define the directory heirarchy for cloud specific tools, scripts resources and tests and encode them into variables for common usage.
The structure we want to use for static files follows this template:
For runtime files (e.g. configuration files set up by boot services), we will store them in:
/var/hpc/<cloud-vendor>/....These common directories will be defined by the following set of variables:
Summary by Sourcery
Add shared variables for Azure-specific HPC resource, tools, tests, and runtime directories under /opt/hpc/azure and /var/hpc/azure for consistent usage across the project.
Enhancements: