added support for canfd frames for SavvyCan V220 app #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marckleinebudde
requested changes
Jun 5, 2025
Member
marckleinebudde
left a comment
marckleinebudde
left a comment
There was a problem hiding this comment.
Your patch add some trailing white space, can you please remove them.
Comment on lines
+100
to
+104
| if (setsockopt(raw_socket, SOL_CAN_RAW, CAN_RAW_FD_FRAMES, &enable, sizeof(enable)) < 0) { | ||
| PRINT_ERROR("Could not enable CAN FD\n"); | ||
| state = STATE_SHUTDOWN; | ||
| return; | ||
| } |
Member
There was a problem hiding this comment.
This will fail on CAN CC only devices, right? I think we want an option to enable CAN-FD.
Author
There was a problem hiding this comment.
I think you are right. So what kind of option need to added ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code is adding support for transmiting can and canfd frames in a single tag's frame and send , so app like SavvyCan V220 is work fine with that rx and tx data for booth can and canfd as is.