-
Notifications
You must be signed in to change notification settings - Fork 60
Enable error frame reception in raw mode #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable error frame reception in raw mode #67
Conversation
|
Hello @occam25 , The Error Messages can create a very high traffic load. Therefore switching "on" everything by default is not a good choice. I would suggest to create a new command line option |
|
Hi @hartkopp , |
|
The check that is failing seems to be a dependency problem when podman tries to build the image, nothing related to my changes |
yes, Debian experimental is sometimes inconsistent. no worries. |
marckleinebudde
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution, and implementing the requests by Oliver. I've some minor nitpicks.
148571a to
cd56d66
Compare
|
Merged to master and reworked the help text afterwards. |
marckleinebudde
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary
I was unable to receive error frame messages in RAW mode because the code to enable error frames in the raw socket was missing (although the
CAN_ERR_FLAGis checked for every frame).I have added the code to enable the error frames in the raw socket after it is created (it makes sense to do it there because in RAW mode the user expects to receive everything).
Now I do receive the error messages as expected.