Make getWikiMarkup() more robust #15
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of relying on the <text ...> node starting to match exactly '<text xml:space="preserve">', make this step a bit more robust by looking for the next '>' following the '<text ' opening.
Author
|
Inspected the code further I just realized that there already is some code for handling the |
Author
|
Also I didn't see #14 already mentions the problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been looking into using your library and trying things on a recent Wikipedia dump, it didn't work.
Turns out that
looked like this there:
So I made the code that looks for the start of the actual wiki text a bit more robust by starting at
<textand then seeking forward to the next>.