Optimize build: Remove shadowJar from build task #423
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove shadowJar from build task to speed up development builds by 56%.
The
build.dependsOn shadowJarwas explicitly added but is unnecessary because the Shadow plugin's maven-publish integration already triggers shadowJar when runningpublish. CI workflows are unaffected since./gradlew publishruns before Docker builds.Build time improvement (
./gradlew clean build -x test):Changes
Performance Improvements
Removed
tasks.build.dependsOn tasks.shadowJarfrom:buildSrc/src/main/groovy/openhouse.apps-spark-common.gradletables-test-fixtures/tables-test-fixtures-iceberg-1.2/build.gradletables-test-fixtures/tables-test-fixtures-iceberg-1.5/build.gradleWhy this is safe:
publishtask already triggersshadowJarvia Shadow plugin's maven-publish integration./gradlew publishbefore Docker buildsconfiguration: 'shadow'still trigger shadowJar for their dependenciesBefore (shadowJar runs on every build):
After (shadowJar only runs on publish):
Testing Done
Manual Testing
./gradlew clean build -x testno longer runs shadowJar tasks./gradlew publish --dry-runstill triggers shadowJarNo Tests Added
This is a build infrastructure change that doesn't affect runtime behavior.
Additional Information
🤖 Generated with Claude Code