feat(compiler): move translation service initialization to see the logs #1705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AleksandrSl
commented
Dec 23, 2025
| `Initializing Lingo.dev compiler. Is dev mode: ${isDev}. Is main runner: ${isMainRunner()}`, | ||
| ); | ||
|
|
||
| // TODO (AleksandrSl 12/12/2025): Add API keys validation too, so we can log it nicely. |
Collaborator
Author
There was a problem hiding this comment.
That's what is solved in the PR
AleksandrSl
commented
Dec 23, 2025
Comment on lines
-750
to
-752
| if (!this.translationService) { | ||
| throw new Error("Translation service not initialized"); | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
Quite dumb check, we make sure TranslationService is never null in constructor, since it's not something heavy we should delay creating
AleksandrSl
commented
Dec 23, 2025
| const delay = this.config?.delayMedian ?? 0; | ||
| const actualDelay = this.getRandomDelay(delay); | ||
|
|
||
| this.logger.debug( |
Collaborator
Author
There was a problem hiding this comment.
These were mostly added by LLM for debugging, we can add them back with LLM if needed
AleksandrSl
force-pushed
the
feat/compiler-show-translation-service-logs-in-console
branch
3 times, most recently
from
91c0bef to
85ceb48
Compare
We don't really need to initialize it inside the server, since server is only a way to use the service in the dev mode. Logs of the server are written to a file due to it being started from process which doesn't have access to console. But we want to see TranslationService initialization logs in the console, and the clearest way is to start it early, rather than extracting validation into a separate function.
AleksandrSl
force-pushed
the
feat/compiler-show-translation-service-logs-in-console
branch
from
85ceb48 to
bed9c1f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We don't really need to initialize it inside the server, since server is only a way to use the service in the dev mode.
Logs of the server are written to a file due to it being started from process which doesn't have access to console. But we want to see TranslationService initialization logs in the console, and the clearest way is to start it early, rather than extracting validation into a separate function.
Changes
Checklist