Skip to content

Conversation

@wmedrano
Copy link
Collaborator

@wmedrano wmedrano commented Jan 26, 2026

Implement sweep gradient. Ported from Skia

@wmedrano wmedrano force-pushed the sweep branch 2 times, most recently from 8c93862 to 4267464 Compare January 26, 2026 20:10
@RazrFalcon
Copy link
Collaborator

Pretty clean. Looks good. Thanks! 👍

As for xy_to_unit_angle and LowP. It's fine to keep it HighP for now, but it seems like the code is nearly identical.
Up to you. We could add a comment like:

// TODO: can be implemented for lowp as well
null_fn, // XYToUnitAngle

@wmedrano wmedrano marked this pull request as ready for review January 26, 2026 21:16
@wmedrano
Copy link
Collaborator Author

Pretty clean. Looks good. Thanks! 👍

As for xy_to_unit_angle and LowP. It's fine to keep it HighP for now, but it seems like the code is nearly identical. Up to you. We could add a comment like:

// TODO: can be implemented for lowp as well
null_fn, // XYToUnitAngle

Ack, added comments. It requires a bit more code than it seems since we are missing some functions for f32x16 and lowp for concentric conical bias.

@RazrFalcon
Copy link
Collaborator

RazrFalcon commented Jan 27, 2026

Got it. Makes sense.

Copy link
Contributor

@LaurenzV LaurenzV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't double-checked the implementation, but seems good to me.

@LaurenzV LaurenzV changed the title Implement sweep gradient Add support for sweep gradients Jan 27, 2026
@LaurenzV LaurenzV merged commit 2df5c25 into linebender:main Jan 27, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants