Conversation
* Added Py3 support (tests python3.5)
* NTP Header tuning to comply with NTP4
* Provision for custom delay used for testing
* Some Useful printouts added
Signed-off-by: Jacques Samoun <jacques.samoun@non.se.com>
Young-Lord
reviewed
Apr 4, 2024
| socket.bind((listenIp,listenPort)) | ||
| print ("local socket: %s " % str(socket.getsockname())) | ||
|
|
||
| recvThread = RecvThread(socket, 240) # Use 240 secs offset for testing |
There was a problem hiding this comment.
Is there a breaking change here? testing code should not appear in pr IMHO,
Young-Lord
reviewed
Apr 4, 2024
| try: | ||
| data,addr,recvTimestamp = taskQueue.get(timeout=1) | ||
| recvPacket = NTPPacket() | ||
| data,addr,recvTimestamp = taskQueue.get(timeout=10) # will generate an exception |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jacques Samoun jacques.samoun@non.se.com