Skip to content

typo in NewEdnpoint 2nd param #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nadilas wants to merge 2 commits into
base: master
Choose a base branch
from
Open

typo in NewEdnpoint 2nd param #3

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9bd3e67
typo in NewEdnpoint 2nd param
nadilas Jun 11, 2020
9ee38fa
Update fromenv.go
nadilas Jun 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions fromenv.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import (

var zipkinReporter reporter.Reporter

func Tracer(name string) opentracing.Tracer {
func Tracer(name string, opts ...zipkinhttp.ReporterOption) opentracing.Tracer {
zipkinHost := os.Getenv("USE_ZIPKIN")
if zipkinHost == "" {
return opentracing.GlobalTracer()
Expand All @@ -30,10 +30,10 @@ func Tracer(name string) opentracing.Tracer {
}

// create our local service endpoint
endpoint, _ := zipkin.NewEndpoint(name, name)
endpoint, _ := zipkin.NewEndpoint(name, "localhost:0")

logrus.Infof("Using Zipkin HTTP tracer: %s", addr)
zipkinReporter = zipkinhttp.NewReporter(addr)
zipkinReporter = zipkinhttp.NewReporter(addr, opts...)

// initialize our tracer
nativeTracer, err := zipkin.NewTracer(zipkinReporter, zipkin.WithLocalEndpoint(endpoint))
Expand Down