-
Notifications
You must be signed in to change notification settings - Fork 63
konflux: use wheels from RHOAI index #994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,7 +7,7 @@ PATH_TO_PLANTUML := ~/bin | |
| PYTHON_REGISTRY = pypi | ||
|
|
||
| # PyTorch version | ||
| TORCH_VERSION := 2.7.1 | ||
| TORCH_VERSION := 2.9.0 | ||
|
|
||
|
|
||
| run: ## Run the service locally | ||
|
|
@@ -111,14 +111,7 @@ upload-distribution-archives: ## Upload distribution archives into Python regist | |
| uv run python -m twine upload --repository ${PYTHON_REGISTRY} dist/* | ||
|
|
||
| konflux-requirements: ## generate hermetic requirements.*.txt file for konflux build | ||
| uv pip compile pyproject.toml -o requirements.x86_64.txt --generate-hashes --group llslibdev --python-platform x86_64-unknown-linux-gnu --torch-backend cpu --python-version 3.12 --refresh | ||
| uv pip compile pyproject.toml -o requirements.aarch64.txt --generate-hashes --group llslibdev --python-platform aarch64-unknown-linux-gnu --torch-backend cpu --python-version 3.12 --refresh | ||
| ./scripts/remove_torch_deps.sh requirements.x86_64.txt | ||
| ./scripts/remove_torch_deps.sh requirements.aarch64.txt | ||
| echo "torch==${TORCH_VERSION}" | uv pip compile - -o requirements.torch.txt --generate-hashes --python-version 3.12 --torch-backend cpu --emit-index-url --no-deps --index-url https://download.pytorch.org/whl/cpu --refresh | ||
| uv run pybuild-deps compile --output-file=requirements-build.txt \ | ||
| <(grep -v "^faiss-cpu" requirements.hermetic.txt) \ | ||
| <(grep -Eo "^[a-zA-Z0-9][-a-zA-Z0-9._]*==[^ ]+" requirements.x86_64.txt | grep -v "^faiss-cpu") | ||
| ./scripts/konflux_requirements.sh | ||
|
Comment on lines
113
to
+114
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
# First, check if the script exists
if [ -f scripts/konflux_requirements.sh ]; then
echo "=== Checking for error handling in scripts/konflux_requirements.sh ==="
echo ""
echo "--- First 30 lines of the script ---"
head -30 scripts/konflux_requirements.sh
echo ""
echo "--- Searching for set directives ---"
grep -n "^set -" scripts/konflux_requirements.sh || echo "No 'set -' directives found at line start"
else
echo "ERROR: scripts/konflux_requirements.sh not found"
ls -la scripts/ 2>/dev/null || echo "scripts directory not found"
fiRepository: lightspeed-core/lightspeed-stack Length of output: 1325 Add error handling directives to The script is missing This ensures the script exits immediately on any command failure or pipe error, preventing partial/corrupted output files from progressing to the build pipeline. 🤖 Prompt for AI Agents |
||
|
|
||
| help: ## Show this help screen | ||
| @echo 'Usage: make <OPTIONS> ... <TARGETS>' | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: lightspeed-core/lightspeed-stack
Length of output: 162
🏁 Script executed:
Repository: lightspeed-core/lightspeed-stack
Length of output: 215
🏁 Script executed:
Repository: lightspeed-core/lightspeed-stack
Length of output: 1788
Fix the generator script to produce sorted package output.
The packages list (121 items) is not sorted:
uvappears at position 119 but should be alphabetically earlier. While the long line length itself is acceptable for auto-generated content, the unsorted state indicates thekonflux_requirements.shgenerator is not producing consistent output, making diffs harder to review. Ensure the generator sorts packages alphabetically.🤖 Prompt for AI Agents