Closed
Conversation
zhenlu
reviewed
Mar 11, 2025
| #[serde(rename = "REGTEST_MANAGE")] | ||
| RegtestManage, | ||
|
|
||
| #[serde(rename = "SIGNET_VIEW")] |
Contributor
There was a problem hiding this comment.
Is this generated or modified manually?
Contributor
Author
There was a problem hiding this comment.
modified manually. should it be generated?
Contributor
Author
There was a problem hiding this comment.
oh I see they need to be regenerated, I will need someone's help to do it and then publish so it can be used in go-sdk. I also tried to build go-sdk docker image on my laptop, but it's pain to use replace in go.mod to get lightspark-rs from another folder.
yellowred
force-pushed
the
oleg/enable_signet
branch
from
6b20674 to
d6488b6
Compare
Contributor
Author
|
Closing because it needs to be generated differently |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump the versions to enable Signet network in the code that is used in the remote signer for Sparknode. This will allow testing lightning payments to Spark using Signet.
Towards LPT-225