Skip to content

Fix greptile comments#229

Closed
AaryamanBhute wants to merge 2 commits intomainfrom
add-ngn-and-cad-v2
Closed

Fix greptile comments#229
AaryamanBhute wants to merge 2 commits intomainfrom
add-ngn-and-cad-v2

Conversation

@AaryamanBhute
Copy link
Contributor

No description provided.

@AaryamanBhute AaryamanBhute changed the title Add ngn and cad v2 Fix greptile comments Feb 25, 2026
AaryamanBhute and others added 2 commits February 24, 2026 22:10
Add `title: Individual Beneficiary` to CadBeneficiary and
NgnBeneficiary to match all other beneficiary schemas and
fix Mintlify rendering.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Remove redundant title attributes from $ref siblings in
CadExternalAccountInfo, NgnExternalAccountInfo, and
ExternalAccountInfoOneOf. Titles live in the schema files
themselves per the pattern established in PR #221.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@github-actions
Copy link
Contributor

github-actions bot commented Feb 25, 2026

✱ Stainless preview builds

This PR will update the grid SDKs with the following commit messages.

kotlin

chore(internal): regenerate SDK with no functional changes

openapi

chore(internal): regenerate SDK with no functional changes

python

chore(internal): regenerate SDK with no functional changes

typescript

chore(internal): regenerate SDK with no functional changes

Edit this comment to update them. They will appear in their respective SDK's changelogs.

grid-openapi studio · code · diff

Your SDK build had at least one "note" diagnostic, but this did not represent a regression.
generate ✅

grid-python studio · code · diff

Your SDK build had at least one "note" diagnostic, but this did not represent a regression.
generate ✅build ✅lint ✅test ✅

pip install https://pkg.stainless.com/s/grid-python/5ad56989429a57b3df591741e10bd93394a1bdb2/grid-0.0.1-py3-none-any.whl
grid-kotlin studio · code · diff

Your SDK build had at least one "note" diagnostic, but this did not represent a regression.
generate ✅build ✅lint ✅test ✅

grid-typescript studio · code · diff

Your SDK build had at least one "note" diagnostic, but this did not represent a regression.
generate ✅build ✅lint ✅test ✅

npm install https://pkg.stainless.com/s/grid-typescript/0725761f090c5710d6c66b8d15b803c436e9b36b/dist.tar.gz

This comment is auto-generated by GitHub Actions and is automatically kept up to date as you push.
If you push custom code to the preview branch, re-run this workflow to update the comment.
Last updated: 2026-02-25 06:16:18 UTC

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 25, 2026

Greptile Summary

Applied the PR #221 pattern to newly added NGN and CAD schemas by moving title fields from $ref siblings into schema definitions and removing inline titles from oneOf blocks.

Changes made:

  • Added title: Individual Beneficiary to CadBeneficiary.yaml and NgnBeneficiary.yaml schema files
  • Removed inline title fields from $ref siblings in CadExternalAccountInfo.yaml and NgnExternalAccountInfo.yaml beneficiary oneOf blocks
  • Removed all 23 inline title fields from ExternalAccountInfoOneOf.yaml to maintain consistency across all external account types
  • Regenerated bundled openapi.yaml and mintlify/openapi.yaml files

This ensures Mintlify correctly resolves schema titles during rendering and prevents duplicate type options in the API documentation.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The changes correctly apply an established pattern from PR fix: remove duplicate discriminators and move titles to fix Mintlify rendering #221 to maintain consistency across OpenAPI schemas. All modifications follow the documented convention of placing titles in schema definitions rather than as $ref siblings, which is required for proper Mintlify rendering. The bundled files were correctly regenerated to reflect source changes.
  • No files require special attention

Important Files Changed

Filename Overview
openapi/components/schemas/common/CadBeneficiary.yaml Added title field to schema definition following PR #221 pattern
openapi/components/schemas/common/NgnBeneficiary.yaml Added title field to schema definition following PR #221 pattern
openapi/components/schemas/external_accounts/CadExternalAccountInfo.yaml Removed inline title fields from $ref siblings in oneOf block, consistent with PR #221
openapi/components/schemas/external_accounts/NgnExternalAccountInfo.yaml Removed inline title fields from $ref siblings in oneOf block, consistent with PR #221
openapi/components/schemas/external_accounts/ExternalAccountInfoOneOf.yaml Removed all inline title fields from 23 $ref entries in oneOf, matching PR #221 pattern

Last reviewed commit: c20aad5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant