fix: remove remaining title/$ref siblings and add missing titles#228
fix: remove remaining title/$ref siblings and add missing titles#228AaryamanBhute merged 2 commits intomainfrom
Conversation
- Remove title lines from ExternalAccountInfoOneOf.yaml oneOf entries (titles as $ref siblings are ignored per OpenAPI spec) - Remove title/$ref siblings from CadExternalAccountInfo and NgnExternalAccountInfo beneficiary oneOf entries - Add missing titles to CadBeneficiary.yaml and NgnBeneficiary.yaml Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
✱ Stainless preview buildsThis PR will update the kotlin openapi python typescript ✅ grid-python studio · code
✅ grid-kotlin studio · code
✅ grid-typescript studio · code
This comment is auto-generated by GitHub Actions and is automatically kept up to date as you push. |
Greptile SummaryThis PR fixes OpenAPI spec compliance issues that were preventing Mintlify from rendering discriminated union type selectors correctly. The changes remove Changes made:
This change ensures Mintlify can properly display type selector labels for external account info and beneficiary oneOf unions. Confidence Score: 5/5
|
| Filename | Overview |
|---|---|
| openapi/components/schemas/external_accounts/ExternalAccountInfoOneOf.yaml | Removed 22 title/$ref siblings that were ignored by OpenAPI spec, properly relying on titles within referenced schemas |
| openapi/components/schemas/common/CadBeneficiary.yaml | Added missing title: Individual Beneficiary to enable proper Mintlify oneOf rendering |
| openapi/components/schemas/common/NgnBeneficiary.yaml | Added missing title: Individual Beneficiary to enable proper Mintlify oneOf rendering |
| openapi/components/schemas/external_accounts/CadExternalAccountInfo.yaml | Removed title/$ref siblings from beneficiary oneOf, now properly relies on schema titles |
| openapi/components/schemas/external_accounts/NgnExternalAccountInfo.yaml | Removed title/$ref siblings from beneficiary oneOf, now properly relies on schema titles |
| openapi/README.md | Added comprehensive documentation on title placement and discriminator location best practices |
Last reviewed commit: 8531eac
…ADME Document two common pitfalls when defining oneOf schemas: - Discriminators must only exist on the OneOf wrapper, not base schemas - Titles must be inside referenced schema files, not as $ref siblings Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Summary
title:lines that were siblings to$ref:inExternalAccountInfoOneOf.yaml(22 entries) — these are ignored per the OpenAPI spec and cause Mintlify to not display titles correctlytitle:/$ref:sibling pattern fromCadExternalAccountInfoandNgnExternalAccountInfobeneficiary oneOf entries (added in feat: add NGN and CAD external account and beneficiary schemas #226)title: Individual BeneficiarytoCadBeneficiary.yamlandNgnBeneficiary.yamlso Mintlify renders the oneOf type selector properlyTest plan
make buildpassesmake lintpasses (22 pre-existing warnings, 0 errors)🤖 Generated with Claude Code