Support PerformanceObserver API
#1282
Open
+309
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Heavily based on MutationObserver and IntersectionObserver.
This still needs investigation. Spec doesn't refer usage of microtask queue for this, yet the current behavior doesn't match to Firefox and Chrome.
nikneym
force-pushed
the
nikneym/performance-observer
branch
from
459cef0 to
e1ba5df
Compare
mookums
reviewed
Dec 22, 2025
Contributor
There was a problem hiding this comment.
Doesn't seem like this file is used anywhere in this PR?
karlseguin
reviewed
Dec 23, 2025
| const ShadowRoot = @import("webapi/ShadowRoot.zig"); | ||
| const Performance = @import("webapi/Performance.zig"); | ||
| const Screen = @import("webapi/Screen.zig"); | ||
| const HtmlScript = @import("webapi/Element.zig").Html.Script; |
Collaborator
There was a problem hiding this comment.
Not used? (Can always use Element.Html.Script)
| struct { | ||
| fn run(_page: *anyopaque) anyerror!?u32 { | ||
| const page: *Page = @ptrCast(@alignCast(_page)); | ||
| page._performance_delivery_scheduled = true; |
Collaborator
There was a problem hiding this comment.
This should be set to false?
| /// This doesn't emit callbacks but rather fills the queues of observers. | ||
| pub fn notifyPerformanceObservers(self: *Page, entry: *Performance.Entry) !void { | ||
| for (self._performance_observers.items) |observer| { | ||
| if (observer.interested(entry)) { |
Collaborator
There was a problem hiding this comment.
I might encapsulate this in the observer, so just:
observer.newEntry(entry)and let it decide how/if to handle it.
| page._performance_delivery_scheduled = true; | ||
| // Dispatch performance observer events. | ||
| for (page._performance_observers.items) |observer| { | ||
| if (observer.hasRecords()) { |
Collaborator
There was a problem hiding this comment.
again, maybe just call observer.dispatch() and let it deal with what (if anything) to do.
| pub const prototype_chain = bridge.prototypeChain(); | ||
| pub var class_id: bridge.ClassId = undefined; | ||
|
|
||
| pub const getEntries = bridge.function(EntryList.getEntries, .{}); |
Collaborator
There was a problem hiding this comment.
This should be defined in JsApi, not Meta. This tells me there might be some tests missing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements
PerformanceObserverformarkandmeasureperformance types. I'll add tests also but would like to receive reviews before that.