cmd/lncli: add new delpayments command line option#5778
Closed
Roasbeef wants to merge 2 commits intolightningnetwork:masterfrom
Closed
cmd/lncli: add new delpayments command line option#5778Roasbeef wants to merge 2 commits intolightningnetwork:masterfrom
Roasbeef wants to merge 2 commits intolightningnetwork:masterfrom
Conversation
In this commit, we add a new CLI command to `lncli`: `delpayments`. This command exposes the `DeleteAllPayments` command over command line, with a set of arguments that should make it difficult to use improperly. We require that the user _explicitly_ specify if they want to delta all payments, just failed payments, or failed HTLC payments.
Roasbeef
force-pushed
the
del-failed-payments-cmd
branch
from
860e508 to
8c85142
Compare
Collaborator
|
Duplicate of #5699? |
dstadulis
reviewed
Sep 23, 2021
| var deletePaymentsCommand = cli.Command{ | ||
| Name: "delpayments", | ||
| Category: "payments", | ||
| Usage: "Delete all payments, only failed payments, or only the HTLCs associated with faild payments", |
There was a problem hiding this comment.
Suggested change
| Usage: "Delete all payments, only failed payments, or only the HTLCs associated with faild payments", | |
| Usage: "Delete all payments, only failed payments, or only the HTLCs associated with failed payments", |
Typo: missing e
|
|
||
| // Show command help if no arguments provided | ||
| if ctx.NArg() == 0 && ctx.NumFlags() == 0 { | ||
| cli.ShowCommandHelp(ctx, "delpayments") |
There was a problem hiding this comment.
FWIW golinter errcheck flags this line
cmd/lncli/commands.go:2864:22: Error return value of `cli.ShowCommandHelp` is not checked (errcheck)
cli.ShowCommandHelp(ctx, "delpayments")
^
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this commit, we add a new CLI command to
lncli:delpayments. Thiscommand exposes the
DeleteAllPaymentscommand over command line, witha set of arguments that should make it difficult to use improperly. We
require that the user explicitly specify if they want to delta all
payments, just failed payments, or failed HTLC payments.