Skip to content

Conversation

@sunsetkookaburra
Copy link

libesedb_multi_value_get_value_binary_data incorrectly guarded for text type instead of binary data. fixed in this patch

@codecov
Copy link

codecov bot commented Jan 11, 2024

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.83%. Comparing base (c0f3fc2) to head (709cb7e).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
libesedb/libesedb_multi_value.c 0.00% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (c0f3fc2) and HEAD (709cb7e). Click for more details.

HEAD has 6 uploads less than BASE
Flag BASE (c0f3fc2) HEAD (709cb7e)
8 2
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #69      +/-   ##
==========================================
- Coverage   22.19%   16.83%   -5.37%     
==========================================
  Files          53       53              
  Lines       12299    12296       -3     
  Branches     2843     2842       -1     
==========================================
- Hits         2730     2070     -660     
- Misses       9141     9894     +753     
+ Partials      428      332      -96     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@joachimmetz
Copy link
Member

Thanks for the proposed changes I'll have a look when time permits

@sunsetkookaburra sunsetkookaburra changed the title fix: multi value column type guard fix: multi value binary column type guard Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants