feat(transports/unix-stream): add#6056
Open
nabijaczleweli wants to merge 1 commit intolibp2p:masterfrom
Open
Conversation
cf4a285 to
7474677
Compare
19d5dd4 to
eebc01c
Compare
Ripped 100% off transports/tcp Uses proposed encoding from multiformats/multiaddr#174 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This allows dialling with and listening on AF_UNIX/SOCK_STREAM sockets.
Ripped 100% off transports/tcp, as in I
cp -r tcp unix-streamed it.Uses proposed encoding from multiformats/multiaddr#174 (comment)
Notes & open questions
I called the empty tag enum
UnixStrmdue to a name collision. I don't know what the purpose of it is anyway, but.As for the encoding, I hope to move it entirely into multiaddr; transports/tcp has
and
so the same thing should be available once that lands in multiaddr.
Change checklist