fix(registrar): ensure onDisconnect respects notifyOnLimitedConnection#3376
Open
paschal533 wants to merge 1 commit intolibp2p:mainfrom
Open
fix(registrar): ensure onDisconnect respects notifyOnLimitedConnection#3376paschal533 wants to merge 1 commit intolibp2p:mainfrom
paschal533 wants to merge 1 commit intolibp2p:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title
fix(registrar): ensure onDisconnect respects notifyOnLimitedConnection
Description
Fixed an inconsistency in topology notification where
onDisconnectcould fire for connections that never triggeredonConnect.When a topology has
notifyOnLimitedConnectionunset (defaultfalse), connections with limits (like circuit relay connections used for WebRTC SDP signaling) correctly skiponConnect. However, when these connections closed,onDisconnectwas still being called due to a logic error in_onDisconnect:This caused spurious disconnect events in protocol handlers like GossipSub when WebRTC browser-to-browser connections use temporary relay connections for SDP exchange.
Fixes #2647
Fixes #2369
Notes & open questions
transport-webrtcbecause circuit relay v2 connections already haveconnection.limitsset. The bug was purely in the registrar's disconnect notification logic.undefined === false → false) is a subtle JS gotcha that allowed this to go undetected.Change checklist