feat: track protocol stream open/close count in metrics#3374
Open
Patrick-Ehimen wants to merge 1 commit intolibp2p:mainfrom
Open
feat: track protocol stream open/close count in metrics#3374Patrick-Ehimen wants to merge 1 commit intolibp2p:mainfrom
Patrick-Ehimen wants to merge 1 commit intolibp2p:mainfrom
Conversation
Adds two new counter metrics to complement the existing gauge: - libp2p_protocol_streams_opened_total - libp2p_protocol_streams_closed_total These counters enable calculating stream open/close rates and total throughput over time, addressing the limitations of the existing gauge metric which only shows current state. Fixes libp2p#3262
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
libp2p_protocol_streams_opened_total- incremented when a stream is openedlibp2p_protocol_streams_closed_total- incremented when a stream is closed{direction} {protocol}libp2p_protocol_streams_totalgauge for backward compatibilityMotivation
The existing gauge metric only shows current state. These counters enable:
rate()orincrease()opened_total - closed_totalTest plan
Fixes #3262