This repository was archived by the owner on Jun 26, 2023. It is now read-only.
feat: add getAddresses function to return detailed address info#387
Draft
achingbrain wants to merge 1 commit intomasterfrom
Draft
feat: add getAddresses function to return detailed address info#387achingbrain wants to merge 1 commit intomasterfrom
achingbrain wants to merge 1 commit intomasterfrom
Conversation
Returning a plain list of multiaddrs isn't enough to know what is going on with the state of a node's addresses. This PR adds a `getAddresses` function that returns detailed info about the addresses - are they being announced, was it an observed address, are we confident that the observed address is publicly routable, etc.
maschad
approved these changes
May 10, 2023
Member
maschad
left a comment
maschad
left a comment
There was a problem hiding this comment.
Look good, we should add this method to js-libp2p first and then this can be merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Returning a plain list of multiaddrs isn't enough to know what is going on with the state of a node's addresses.
This PR adds a
getAddressesfunction that returns detailed info about the addresses - are they being announced, was it an observed address, are we confident that the observed address is publicly routable, etc.