Configure basic pre-commit hooks#188
Merged
avalentino merged 1 commit intoliberfa:mainfrom Dec 21, 2025
Merged
Conversation
eerovaher
commented
Dec 2, 2025
| @@ -0,0 +1,18 @@ | |||
| ci: | |||
| autofix_prs: false | |||
| autoupdate_schedule: 'monthly' | |||
Contributor
Author
There was a problem hiding this comment.
In astropy we update monthly.
Contributor
There was a problem hiding this comment.
Given this repo's activity I would go with quarterly instead.
eerovaher
commented
Dec 2, 2025
| rev: v6.0.0 | ||
| hooks: | ||
| - id: check-added-large-files | ||
| args: ["--enforce-all", "--maxkb=100"] |
Contributor
Author
There was a problem hiding this comment.
The default file size limit is 500 kB, but here 100 kB seems to be plenty.
avalentino
approved these changes
Dec 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am adding basic configuration for
pre-commit. It is a tool for managing and running code quality and style checks that is recommended by the Scientific Python Development Guide andastropyhas been using it for quite some time. I am opening the PR with only a few checks, but more can be added either in this PR or in follow-ups. My end goal is to completely replace thecodestyletoxenvironment withpre-commit.pre-commitcan run in CI, but I don't have permissions to set that up here. See the Scientific Python Development Guide and the references within.