added dynamic gui

[Harsha-Samavedam]

Added dynamic gui for logging

[gemini-code-assist]

Summary of Changes

Hello @Harsha-Samavedam, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the user experience of the vehicle model simulation by introducing a comprehensive graphical user interface. The GUI allows users to easily configure simulation parameters, initiate simulations, and visualize the results dynamically through interactive plots, all within a single, responsive application. This change aims to make the simulation framework more accessible and user-friendly for analysis and experimentation.

Highlights

• New GUI Introduction: A new gui.py file has been added, introducing a dynamic graphical user interface built with Tkinter for the vehicle model simulation.
• Interactive Parameter Configuration: The GUI provides a control panel allowing users to dynamically input and override various simulation parameters such as velocity, timestep, weights, and aerodynamic properties, with default values and units displayed.
• Dynamic Data Visualization: Simulation results are now visualized through interactive Matplotlib plots embedded within the GUI. Users can select specific output parameters (e.g., velocity, total_energy, array_power) via checkboxes or custom input, with each parameter displayed in its own tab.
• Asynchronous Simulation Execution: The simulation process runs in a separate thread, ensuring the GUI remains responsive and interactive while the potentially long-running simulation is in progress.
• Real-time Console Output: A dedicated scrolled text area provides real-time logging and status updates from the simulation, including parameter application, progress, and error messages.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• gui.py
  • Added a new Python script gui.py to implement a dynamic GUI for the vehicle model simulation.
  • Implemented a SimulationGUI class using tkinter for the user interface.
  • Included a control panel with input fields for various simulation parameters and their units.
  • Added checkboxes and a custom input field for selecting parameters to be logged and graphed.
  • Integrated matplotlib for plotting simulation data, displaying each selected parameter in a separate tab.
  • Utilized threading to run simulations asynchronously, preventing the GUI from freezing.
  • Incorporated a console output area for real-time status and error logging.
  • Added logic to parse params.yaml and override values with GUI inputs, then run the simulation and plot results.

Activity

• The pull request was created by Harsha-Samavedam, introducing a new dynamic GUI for logging simulation data.
• No further activity (comments, reviews, or approvals) has been recorded yet for this pull request.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a new Tkinter-based graphical user interface in gui.py for running simulations and visualizing results. The GUI allows for dynamic parameter adjustment and runs the simulation in a background thread to maintain UI responsiveness, which is a great feature. My review identifies a few areas for improvement regarding code correctness, maintainability, and adherence to Python best practices. Specifically, I've pointed out a redundant data validation check, a hardcoded value that should be dynamic, and an import statement that should be moved for better code style.

[gemini-code-assist]

The check (self.df[param] == None).all() is redundant and not idiomatic. The preceding self.df[param].isna().all() check already correctly handles None values (along with np.nan), which is the standard way to check for missing data in pandas. You can safely remove the second part of the condition for cleaner and more correct code.

Suggested change

	elif self.df[param].isna().all() or (self.df[param] == None).all():
	elif self.df[param].isna().all():

[gemini-code-assist]

The y-axis limit for the total_energy graph is hardcoded to 5240. This makes the graph axis static even if the user provides a different total_energy value for the simulation, which can be misleading. The axis limit should dynamically reflect the value used in the simulation.

A robust way to fix this would be to pass the params dictionary from _simulation_worker to _create_graphs and then set the limit using the value from that dictionary, for example: ax.set_ylim(0, params['total_energy'].to('Wh').magnitude).