Array Lamination #2 by jana-daouk · Pull Request #44 · lhr-solar/VehicleModel

jana-daouk · 2026-01-31T20:35:24Z

No description provided.

gemini-code-assist · 2026-01-31T20:35:37Z

Summary of Changes

Hello @jana-daouk, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request expands the params.yaml configuration file by adding a new suite of parameters. These additions are designed to enhance the system's ability to model detailed physical and environmental aspects, specifically focusing on the optical properties of lamination layers and various environmental factors affecting array performance.

Highlights

Lamination Optics Parameters: Introduced several new parameters (n_cover, t_cover, alpha_cover, t_eva, alpha_eva, tau_misc, ar_gain) to define the optical properties and absorption characteristics of cover and encapsulant layers.
Array and Environmental Parameters: Added parameters for array_area, ambient_temp, temp_coeff, t_ref, noct, and irradiance_clears to support more comprehensive modeling of array characteristics and environmental conditions.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request adds several new parameters to the params.yaml file, primarily for lamination optics and temperature-related calculations. The changes are straightforward, but I've identified a few areas for improvement to enhance consistency and readability of the configuration file. My review includes suggestions to standardize comment formatting, remove a duplicated comment, and ensure consistent spacing between parameter blocks. Addressing these points will improve the maintainability of the file.

params.yaml

IshDeshpa

still have to look at math.

IshDeshpa · 2026-01-31T21:14:57Z

models/array.py

        super().__init__()

+    # SUN / GEOMETRY
    def _incidence_factor(self, params: dict[str, PlainQuantity[float]]) -> float:


Why wrap everything with float?

IshDeshpa · 2026-01-31T21:20:57Z

models/array.py

+            energy0 = cast(PlainQuantity[float], params["array_power"] * timestep_s)
+            params["array_energy"] = energy0


u could just set array_energy to 0

params.yaml

IshDeshpa · 2026-01-31T21:27:01Z

models/array.py


-        # base max power
-        base_power = params["num_cells"] * params["p_mpp"] * params["cell_efficiency"]
+        energy = cast(PlainQuantity[float], params["array_power"] * timestep_s)


do you need to cast this?

IshDeshpa · 2026-01-31T21:34:28Z

models/array.py

Lots of casting stuff to floats and using cast to cast to PlainQuantities. If this is to satisfy the type checker that's fine, but otherwise if it can be removed you should remove it.

params.yaml

IshDeshpa · 2026-01-31T21:37:08Z

models/array.py

    ) -> PlainQuantity[float]:
-        # Updates array power based on sun angle
-        # accumulates energy into total_array_energy.
-
-        # sunlight factor 0–1
-        factor: PlainQuantity[float] = Q_(
-            self._incidence_factor(params), "dimensionless"
+        inc = self._incidence_factor(params)
+
+        # Normalize timestep to seconds quantity
+        if isinstance(timestep, timedelta):
+            timestep_s: PlainQuantity[float] = Q_(float(timestep.total_seconds()), "s")
+        else:
+            timestep_s = cast(PlainQuantity[float], timestep).to("second")


You can just assume timestep is a PlainQuantity; that's what the EnergyModel specifies should be passed in.

It wasn't taking it as a plainQuantity.

Co-authored-by: Ishan Deshpande <ishdeshpa@gmail.com>

params

cd43c68

array

339e05f

gemini-code-assist bot reviewed Jan 31, 2026

View reviewed changes

params.yaml Show resolved Hide resolved

params.yaml Show resolved Hide resolved

params.yaml Show resolved Hide resolved

yay

1eb4067

jana-daouk changed the title ~~params~~ Array Lamination #2 Jan 31, 2026

IshDeshpa requested changes Jan 31, 2026

View reviewed changes

jana-daouk and others added 4 commits January 31, 2026 15:52

Update params.yaml

c90060f

Co-authored-by: Ishan Deshpande <ishdeshpa@gmail.com>

idk some weird merge conflicts

2fba283

comment

75d584a

comment

adafa09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Array Lamination #2#44

Array Lamination #2#44
jana-daouk wants to merge 7 commits intomainfrom
arrayLamination2

jana-daouk commented Jan 31, 2026

Uh oh!

gemini-code-assist bot commented Jan 31, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

IshDeshpa left a comment

Uh oh!

IshDeshpa Jan 31, 2026

Uh oh!

IshDeshpa Jan 31, 2026

Uh oh!

Uh oh!

Uh oh!

IshDeshpa Jan 31, 2026

Uh oh!

IshDeshpa Jan 31, 2026

Uh oh!

Uh oh!

IshDeshpa Jan 31, 2026

Uh oh!

jana-daouk Jan 31, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		energy0 = cast(PlainQuantity[float], params["array_power"] * timestep_s)
		params["array_energy"] = energy0

Conversation

jana-daouk commented Jan 31, 2026

Uh oh!

gemini-code-assist bot commented Jan 31, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

IshDeshpa left a comment

Choose a reason for hiding this comment

Uh oh!

IshDeshpa Jan 31, 2026

Choose a reason for hiding this comment

Uh oh!

IshDeshpa Jan 31, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

IshDeshpa Jan 31, 2026

Choose a reason for hiding this comment

Uh oh!

IshDeshpa Jan 31, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

IshDeshpa Jan 31, 2026

Choose a reason for hiding this comment

Uh oh!

jana-daouk Jan 31, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants