new Firmware PR

[jennifer1i]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @jennifer1i, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new firmware structure for the project, including core functionalities for motor control and LED management. It also sets up a basic build system using Makefiles. The changes involve creating new directories and files to organize the firmware code and manage dependencies.

Highlights

• Project Restructuring: The PR restructures the project by moving firmware-related files into a dedicated Firmware directory. This includes adding a .gitmodules entry for Firmware/Embedded-Sharepoint and a new .gitignore file within the Firmware directory.
• Core Firmware Implementation: This PR introduces core firmware components such as error handling (err_handler.h, err_handler.c), system clock configuration (sysclk.h, sysclk.c), main application logic (main.h, main.c), and motor task management (motor_task.h, motor_task.c).
• Driver Implementation: The PR includes the implementation of drivers for LED control (led.h, led.c) and PWM signal generation (pwm.h, pwm.c), along with a header file for pin definitions (pinDefs.h).
• Build System Integration: The PR adds a Makefile to the root directory to manage the build process, including options for specifying the target STM32 device and running tests.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a new firmware application for an STM32 microcontroller, including drivers, task structure, and build configurations. The code is a good starting point, but there are several areas for improvement regarding code structure, correctness, and maintainability. My review includes feedback on critical issues like incorrect task loop structures, blocking calls in drivers, and improper variable scoping. I've also pointed out several medium-severity issues such as redundant code, incorrect comments, and style inconsistencies that should be addressed to improve the overall quality of the codebase.

[Rav4s]

Really good job overall! Make sure to add comments throughout and have test files ready before workday. Also look at gemini reviews

[Rav4s]

@jennifer1i don't need both, just use #pragma once

[Rav4s]

Nice work, rlly good progress here. Can you add a test for LEDs (and define the rev b board pins) so we can easily test that at workday