Add CarCAN/BPSCAN dbc files for 2026 vehicle #192
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request consolidates several individual DBC files into a single CarCAN.dbc for the 2026 vehicle. While the consolidation improves organization, several areas require attention to ensure data integrity, clarity, and professionalism. Specifically, there are numerous Vector__XXX placeholders that need to be replaced with actual transmitting nodes, an unprofessional comment in a VAL_TABLE_ needs to be addressed, and some messages lack signals or have redundant comments. Additionally, a TODO comment indicates incomplete work, and an enumerated signal would benefit from a VAL_TABLE_ for better readability.
| CM_ SG_ 80 Accel_Pos_Main "Accelerator Pedal Position (Main Sensor)"; | ||
| CM_ SG_ 1536 LTC4421_HVDCDC_Selected "The LTC4421's channel selected signal for the HV DCDC"; | ||
| CM_ SG_ 768 Supplemental_Battery_Voltage "Supplemental Battery voltage in V"; | ||
| CM_ SG_ 769 SuppCharger_Status "00 - Charging disabled, 01 - Charge done, 10 - Charge in progress, 11 - Charge fault detected"; |
There was a problem hiding this comment.
The comment for SuppCharger_Status describes enumerated states (00, 01, 10, 11). It would be beneficial to define a VAL_TABLE_ for this signal to explicitly map these numeric values to their descriptive states, improving readability and maintainability.
Rav4s
changed the title
3 participants
No description provided.