Allow attempts to load files that don't exist#8
Open
MatthewDarling wants to merge 3 commits intolevand:masterfrom
Open
Allow attempts to load files that don't exist#8MatthewDarling wants to merge 3 commits intolevand:masterfrom
MatthewDarling wants to merge 3 commits intolevand:masterfrom
Conversation
added 3 commits
March 31, 2016 11:17
Also clarify the behaviour when all requested files are missing, in case it changes after PR discussion.
|
This makes a lot of sense. I myself use the pattern in (def config
(apply
conf/load
(filter
(partial not= nil)
[(base-config) (s3-config) (local-config)])))It would of course be great to incorporate this intent, which @MatthewDarling has done, into |
|
@levand would incorporating @MatthewDarling 's changes be made easier if I cherrypicked them into russellwhitaker/immuconf first and made the dual-target clj/cljs conversions there, then issue a follow-up PR? |
|
It would be really useful to be able to "mark" the files as required or not, similar to the default and override tags in the configs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The config loading code for the application I work on looks roughly like this:
Rather than having different code for loading config in prod, we just load a file from a folder that will only exist in the prod environment. And there's a priority list so developers can override things locally.
I think, philosophically, this is very similar to
immuconf. I'm hoping to switch because the tagged literals look great :) However, currentlyimmuconfwill throw an exception if one of the desired files doesn't exist.So, this PR changes
load-cfg-fileso that files that don't exist are ignored. For our application, theresources/config.ednwill always exist so that config will be used if no other files have been created.One case that might need special handling is when all the desired files don't exist. In that case, the config is returned as an empty map... That's probably not desired behaviour, and I can imagine cases where that would break a user's application.