Fix macOS compatibility issues and update Homebrew paths#3
Open
coloboxp wants to merge 1 commit intolessandro:masterfrom
Open
Fix macOS compatibility issues and update Homebrew paths#3coloboxp wants to merge 1 commit intolessandro:masterfrom
coloboxp wants to merge 1 commit intolessandro:masterfrom
Conversation
This commit addresses several compatibility issues to ensure the codebase works well on modern macOS: 1. Replace deprecated BSD function calls: - Replace rindex() with strrchr() for POSIX compliance - This change is reflected in dpymain.c and potentially other files 2. Update X11 paths for macOS Homebrew users: - Change X11 include path to /opt/homebrew/include - Change X11 library path to /opt/homebrew/lib 3. Reorganize header includes: - Properly order system headers before project headers - Ensure proper compilation on platforms with strict include requirements These changes maintain backward compatibility while ensuring the codebase compiles and runs correctly on modern systems.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit addresses several compatibility issues to ensure the codebase works well on modern macOS (M4):
Replace deprecated BSD function calls:
Update X11 paths for macOS Homebrew users:
Reorganize header includes:
These changes maintain backward compatibility while ensuring the codebase compiles and runs correctly on modern systems.