Skip to content

Conversation

@0-Yorick-0
Copy link

@0-Yorick-0 0-Yorick-0 commented Oct 6, 2021

Procédure de Test :

  • après un led up
  • activer xdebug avec led php xdebug -e
  • le désactiver avec led php xdebug -d

@0-Yorick-0 0-Yorick-0 force-pushed the create-xdebug-debugger-plugin branch from 291001c to 8dfe0c9 Compare October 7, 2021 07:41
@bonidier
Copy link
Member

bonidier commented Dec 6, 2021

Hi @0-Yorick-0
can you just apply shellcheck suggestions ?

shellcheck .led/plugins/php.plugin.sh

Copy link
Member

@bonidier bonidier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks useful, just fix review and apply a shellcheck pass on the plugin

local dc_xdebug_env_value

if [[ -f "${origin_xdebug_config_file}" ]]; then
target_xdebug_config=".led/90-xdebug-config.ini"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you must create .led directory if missing, otherwise the sed command can't create output file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants