feat(scripts/autolabel): allow multiple labels, avoid labels of dependent topic areas #34066
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is split into 3 commits, which can be reviewed separately.
Commit 1 & 2 do not change the current behaviour of the script, commit 3 only contains the behaviour-changing config (plus a test).
t-algebrais addedt-datashould never be added". But do not provide any values for this featureMAX_LABELSand specify the dependency-relations between the labels. (also, add a test for commit 2)Testing
Modify some files somewhere in Mathlib, make a temporary commit with these changes and run
lake exe autolabelThis should print all labels which would be added to the PR.Note, that
autolabelcompares the current HEAD toorigin/master(notmasterorupstream/master!) so make sure theorigin/masterof your fork is up-to-date.If there is more discussion needed on (3.) I would suggest moving that commit to a follow-up PR and reviewing the refactoring first which only cleans up the current code.
Zulip discussion: #mathlib reviewers > Proposal: automatic reviewer assignment @ 💬
Q: Do we need to adjust the Zulip-Bot which notifies maintainers about maintainer-merge?