feat(simp_lemmas): allow user congr lemma to have fixed parameters #709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
reviewed
Jun 24, 2022
| @[trans] theorem mod5.trans (a b c : ℕ) : a ≡ b → b ≡ c → a ≡ c := eq.trans | ||
|
|
||
| @[congr] | ||
| theorem mod5.add (a b c d : ℕ) (h₁ : a ≡ b) (h₂ : c ≡ d) : a + c ≡ b + d := sorry |
Member
There was a problem hiding this comment.
Can you add a comment describing what is considered the "fixed" argument here?
eric-wieser
reviewed
Jun 24, 2022
| theorem mod5.add (a b c d : ℕ) (h₁ : a ≡ b) (h₂ : c ≡ d) : a + c ≡ b + d := sorry | ||
|
|
||
| @[congr] | ||
| theorem mod5.congr (a b c d : ℕ) (h1 : a ≡ c) (h2 : b ≡ d) : (a ≡ b) = (c ≡ d) := sorry |
Member
There was a problem hiding this comment.
To avoid the sorry output, maybe this should be an axiom
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress and tentative -- I'm not sure if this is implemented correctly.