feat(init/data/cached): Caching mechanism [WIP] #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This still needs more work on the VM side.
cipher1024
force-pushed
the
master
branch
2 times, most recently
from
08a832d to
217862b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back from the dead (leanprover/lean3#1628). @cipher1024 @EdAyers There were some worrisome review comments about ts_clone that I don't think I addressed before the PR was closed. I'll take another look at it but if either of you know what needs to be done I'd appreciate it.
I'm thinking of renaming
cachedtomutableand eliminating the inhabited argument. Originally I was considering the idea of usingcachedcells for memory reclamation on running programs, but I think we're going a different direction with this and so it doesn't make that much sense anymore.