-
Notifications
You must be signed in to change notification settings - Fork 0
Migrate solution to slnx #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary
🎉 No failed tests in this run. | ⏭️ No skipped tests in this run. Github Test Reporter by CTRF 💚 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #79 +/- ##
=======================================
Coverage 90.09% 90.09%
=======================================
Files 34 34
Lines 747 747
Branches 46 46
=======================================
Hits 673 673
Misses 71 71
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR migrates the solution file from the legacy .sln format to the modern XML-based .slnx format, while also updating some dependency versions.
- Replaces
LeanCode.Pipe.slnwithLeanCode.Pipe.slnxusing the new Visual Studio solution format - Updates
Microsoft.AspNetCore.SignalR.Clientfrom 10.0.0 to 10.0.1 - Updates
csharpiertool from 1.2.1 to 1.2.3
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| publisher/LeanCode.Pipe.slnx | New XML-based solution file containing all 19 projects organized into logical folder structures |
| publisher/LeanCode.Pipe.sln | Removed legacy solution file (323 lines) |
| publisher/Directory.Packages.props | Bumped Microsoft.AspNetCore.SignalR.Client package version to 10.0.1 |
| publisher/.config/dotnet-tools.json | Updated csharpier formatter tool to version 1.2.3 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <Configurations> | ||
| <Platform Name="Any CPU" /> | ||
| <Platform Name="x64" /> | ||
| <Platform Name="x86" /> |
Copilot
AI
Dec 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Configurations section only defines platforms but is missing build type configurations. The old .sln file had both Debug and Release configurations for each platform. In the .slnx format, you should include BuildType elements to define Debug and Release configurations. Without these, the solution may not properly support different build configurations.
| <Platform Name="x86" /> | |
| <Platform Name="x86" /> | |
| <BuildType Name="Debug" /> | |
| <BuildType Name="Release" /> |
No description provided.