-
Notifications
You must be signed in to change notification settings - Fork 0
Migrate to xUnit v3 and Microsoft Testing Platform v2 #78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary
🎉 No failed tests in this run. | ⏭️ No skipped tests in this run. Github Test Reporter by CTRF 💚 🔄 This comment has been updated |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #78 +/- ##
===========================================
+ Coverage 65.67% 90.09% +24.42%
===========================================
Files 37 34 -3
Lines 906 747 -159
Branches 50 46 -4
===========================================
+ Hits 595 673 +78
+ Misses 290 71 -219
+ Partials 21 3 -18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR migrates the test infrastructure from xUnit v2 with VSTest to xUnit v3 with Microsoft Testing Platform v2. This is a significant modernization that simplifies the testing setup and provides better integration with newer .NET tooling.
Key Changes
- Migrated from xUnit v2 (2.9.3) to xUnit v3 (3.2.1) with Microsoft Testing Platform v2 adapter
- Replaced coverlet collector with Microsoft.Testing.Extensions.CodeCoverage for code coverage
- Converted integration test app from minimal APIs to traditional Startup class to resolve WebApplicationFactory compatibility issues with the new testing platform
Reviewed changes
Copilot reviewed 53 out of 53 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| publisher/test/Directory.Build.props | Consolidated test project configuration with global usings, Microsoft Testing Platform setup, and test execution arguments |
| publisher/Directory.Packages.props | Updated test package references from xUnit v2 ecosystem to xUnit v3 with MTP v2 |
| publisher/test/coverage.xml | New Microsoft code coverage configuration replacing coverlet.runsettings |
| publisher/test/coverlet.runsettings | Removed legacy coverlet configuration file |
| publisher/test/*/*.csproj | Removed individual test project package references (now centralized in Directory.Build.props) |
| publisher/test/**/*.cs | Removed explicit using statements for FluentAssertions and Xunit (now global usings), updated CancellationToken usage to TestContext.Current.CancellationToken, changed IAsyncLifetime to return ValueTask |
| publisher/test/LeanCode.Pipe.IntegrationTests/App/Startup.cs | New traditional Startup class to work around WebApplicationFactory issues with Microsoft Testing Platform entry points |
| publisher/test/LeanCode.Pipe.IntegrationTests/App/Program.cs | Removed - replaced by Startup.cs |
| publisher/funnel_test_cluster/*/tests.dockerfile | Changed base image from SDK to aspnet runtime and updated entrypoints to use native executables with --explicit only flag |
| publisher/funnel_test_cluster/run-tests.sh | Updated log parsing to match new test output format from Microsoft Testing Platform |
| .github/workflows/publisher_ci.yml | Simplified test execution (no explicit coverage/logging flags), updated environment variable syntax, added test result processing and CTRF report publishing |
| .github/workflows/publisher_release.yml | Updated test execution commands and environment variable syntax |
| publisher/global.json | Added test runner configuration for Microsoft Testing Platform |
| publisher/.config/dotnet-tools.json | Added dotnet-coverage tool |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.