Skip to content

Conversation

@tcoratger
Copy link
Collaborator

🗒️ Description

@anshalshukla I feel that unifying everything under a single function, rather than distributing it across subfunctions, is clearer and more uniform. Let me know what you think about this.

Since this logic isn't finalized yet, I'd like to avoid multiplying the utility functions to make the specification readable and as compact as possible.

🔗 Related Issues or PRs

✅ Checklist

  • Ran tox checks to avoid unnecessary CI fails:
    uvx tox
  • Considered adding appropriate tests for the changes.
  • Considered updating the online docs in the ./docs/ directory.

@anshalshukla
Copy link
Contributor

I think otherwise, imo it's easier to read a function handling a specific task then to read a single function doing multiple tasks plus it is easier to write tests as well.

@tcoratger
Copy link
Collaborator Author

I think otherwise, imo it's easier to read a function handling a specific task then to read a single function doing multiple tasks plus it is easier to write tests as well.

Sure no problem, what do you think @unnawut and @g11tech ? If you think the same, then we can close :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants