Set PATH and other vars in .profile.d script #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the problem that the config vars (including PATH) might not be set if the buidpack is used together with other buidpacks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I moved the setting of the config vars from the YAML hash in the
releasescript to the.profile.dscript. This should fix the problem that the config vars, including the PATH, might not be set if the buildpack is used together with other buildpacks (see issue #3 which would be fixed with this).Setting config vars in the
releasescript also seems to be deprecated, as it is not mentioned here https://devcenter.heroku.com/articles/buildpack-api#buildpack-api (under bin/release), and here https://devcenter.heroku.com/articles/buildpack-api#default-config-values it is advised to use a.profile.dscript for adding default config values.