Use git config ssh remote url to account for custom ssh aliases#125
Open
senyc wants to merge 2 commits intoldelossa:mainfrom
Open
Use git config ssh remote url to account for custom ssh aliases#125senyc wants to merge 2 commits intoldelossa:mainfrom
senyc wants to merge 2 commits intoldelossa:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I use an alias for my git remote url (so I can use separate
sshkeys for my work and personal gh accounts). Currently the application will default to usingssh_urlwhich is returned from therepos/{owner}/{repo}/pullsendpoint. This will always begit@github.com:<user>/<repo>.git.In my case, and probably for others as well, this leads to the plugin being unable to run the
git_fetchfunction, causing a failure on startup where the user would seefailed to fetch remote branchin the upper-right hand corner, and be unable to do anything.This addition will only do anything if the user is using the
sshgit_protocol, if they are it will default theremote_urlto whatever is configured in git, viagit config --get remote.origin.url. Otherwise the old functionality will be used.