Perf: ⚡ merge if you want to go faster but don't need float support#1
Open
lbillingham wants to merge 7 commits intomainfrom
Open
Perf: ⚡ merge if you want to go faster but don't need float support#1lbillingham wants to merge 7 commits intomainfrom
lbillingham wants to merge 7 commits intomainfrom
Conversation
but BREAK support for float inputs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves away from the shared
itertoolsimplimentations for finding pairs, triplets of the input numbers that sum to a given target.Instead, we
However, we:
I've moved the
floatinput tests out the their own file and away from the CI test pathPerformance benchmarks
with these changes:
itertools, but non-float supporting versionNote the change in units this branch is in microseconds, the itertools version is in milliseconds