Skip to content

Fix SIGFPE on small number of overlaps #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jchorl wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix SIGFPE on small number of overlaps #63

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/cuda/cudapolisher.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,7 @@ void CUDAPolisher::find_overlap_breaking_points(std::vector<std::unique_ptr<Over

// Variables for keeping track of logger progress bar.
uint32_t logger_step = overlaps.size() / RACON_LOGGER_BIN_SIZE;
logger_step = std::max(logger_step, (uint32_t)1);
int32_t log_bar_idx = 0, log_bar_idx_prev = -1;
uint32_t window_idx = 0;
std::mutex mutex_log_bar_idx;
Expand All @@ -130,7 +131,7 @@ void CUDAPolisher::find_overlap_breaking_points(std::vector<std::unique_ptr<Over
if (log_bar_idx == log_bar_idx_prev) {
continue;
}
else if (logger_step != 0 && log_bar_idx < static_cast<int32_t>(RACON_LOGGER_BIN_SIZE))
else if (log_bar_idx < static_cast<int32_t>(RACON_LOGGER_BIN_SIZE))
{
logger_->bar("[racon::CUDAPolisher::initialize] aligning overlaps");
log_bar_idx_prev = log_bar_idx;
Expand Down Expand Up @@ -277,6 +278,7 @@ void CUDAPolisher::polish(std::vector<std::unique_ptr<Sequence>>& dst,

// Variables for keeping track of logger progress bar.
uint32_t logger_step = windows_.size() / RACON_LOGGER_BIN_SIZE;
logger_step = std::max(logger_step, (uint32_t)1);
int32_t log_bar_idx = 0, log_bar_idx_prev = -1;
uint32_t window_idx = 0;
std::mutex mutex_log_bar_idx;
Expand Down Expand Up @@ -315,7 +317,7 @@ void CUDAPolisher::polish(std::vector<std::unique_ptr<Sequence>>& dst,
if (log_bar_idx == log_bar_idx_prev) {
continue;
}
else if (logger_step != 0 && log_bar_idx < static_cast<int32_t>(RACON_LOGGER_BIN_SIZE))
else if (log_bar_idx < static_cast<int32_t>(RACON_LOGGER_BIN_SIZE))
{
while(log_bar_idx_prev <= log_bar_idx)
{
Expand Down