New openzepplin contracts #116
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce to work with latest web3js
…its tedious and add links to the model on the sdk in the README.md
…er will not clean dbg.json
breaking changes: removed openBounties count removed closedBounties count removed bountiesOfAddress fn
|
🎉 DevQuest Score: 100/100 Excellent contribution! High quality code with comprehensive changes. This PR has been evaluated by Vincent AI and scored for the DevQuest bounty system. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades openzepplin to latest contracts
NetworkV2 breaking changes:
removed
canceledBountiescount (read chain logs to assert this)removed
closedBountiescount (read chain logs to assert this)removed
bountiesOfAddress(read chain logs to assert this)removed
markPullRequestReadyForReviewfunction (PRs now are considered marked for review on creation)Network Register changes:
No longer account for
(network.closedBounties() + network.canceledBounties()) == network.bountiesIndex()when closing a network (this should be done at the discretion of the governor of the network)