Update ruby versions in CI matrix #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Wouldn't be easier to cut old Rubies? 🤔 Is there any reason to support them? |
lautis
force-pushed
the
update-ci-matrix
branch
from
9e05c56 to
a3655ce
Compare
lautis
force-pushed
the
update-ci-matrix
branch
from
a3655ce to
cbf98c9
Compare
Owner
Author
|
The 2.x could be dropped for sure, but the changes are not that hard yet. Minitest 6.x will make things more complex to keep maintaining old versions. |
Contributor
Yup, some deps doesn't work with old Rubies anymore and are painful to conditionally enable/disable. Happy to help if needed. Thanks for maintaining this gem! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new rubies to CI test matrix, and ignore some failing combinations. Update development and CI dependencies to make CI pass.