chore: Support persistent data store verification in contract tests#402
Merged
chore: Support persistent data store verification in contract tests#402
Conversation
BEGIN_COMMIT_OVERRIDE chore: Support persistent data store verification in contract tests fix: Update Redis to write missing `$inited` key fix: Redis store is considered initialized when `$inited` key is written END_COMMIT_OVERRIDE
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
jsonbailey
approved these changes
Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
chore: Support persistent data store verification in contract tests
fix: Update Redis to write missing
$initedkeyfix: Redis store is considered initialized when
$initedkey is writtenEND_COMMIT_OVERRIDE
Note
Medium Risk
Touches client evaluation/initialization gating and persistent store initialization semantics, which could affect flag evaluations during startup or when relying on cached data; changes are scoped and mainly exercised via contract tests.
Overview
CI contract tests now run with persistent-store verification enabled for both v2 and v3 (bumped to
v3.0.0-alpha.2).The contract test service advertises persistent store capabilities and the Python contract-test client can now configure persistent feature stores (and v3
dataSystemstores/modes) for Redis, DynamoDB, and Consul, including cache settings.SDK behavior is adjusted to treat cached persistent-store data as usable before full initialization, and the Redis feature store now writes/reads the
$initedkey during init to correctly report initialization.Written by Cursor Bugbot for commit 84f89e8. This will update automatically on new commits. Configure here.