chore: Remove dead code, clarify names, other cleanup#398
Merged
jsonbailey merged 8 commits intomainfrom Feb 4, 2026
Merged
Conversation
keelerm84
reviewed
Feb 4, 2026
keelerm84
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Touches core polling/streaming and persistence decision logic; changes could affect whether data is persisted or when the client stops/reverts during fallback, though behavior is now more explicit and tests were added.
Overview
Improves FDv2 data-source behavior around selector handling, persistence, and fallback.
ChangeSetBuilder.no_changes()now returns an explicitSelector.no_selector()(instead ofNone), and polling persistence is only enabled when the selector is defined—preventing FDv1 fallback payloads (which have no selector) from being written to persistent storage.Cleans up endpoint constant naming (
FDV1_POLLING_ENDPOINT,FDV2_POLLING_ENDPOINT), removes unusedRepeatingTaskwiring inPollingDataSource, and ensures streaming shuts down immediately when the server indicatesrevert_to_fdv1.Includes small store/apply_delta cleanup, docstring typo fixes, and test updates/additions to cover FDv1 payload parsing and the new persistence/selector semantics.
Written by Cursor Bugbot for commit 86a0671. This will update automatically on new commits. Configure here.