Skip to content

chore: Remove dead code, clarify names, other cleanup#398

Merged
jsonbailey merged 8 commits intomainfrom
jb/sdk-1748/minor-changes
Feb 4, 2026
Merged

chore: Remove dead code, clarify names, other cleanup#398
jsonbailey merged 8 commits intomainfrom
jb/sdk-1748/minor-changes

Conversation

@jsonbailey
Copy link
Contributor

@jsonbailey jsonbailey commented Jan 13, 2026

Note

Medium Risk
Touches core polling/streaming and persistence decision logic; changes could affect whether data is persisted or when the client stops/reverts during fallback, though behavior is now more explicit and tests were added.

Overview
Improves FDv2 data-source behavior around selector handling, persistence, and fallback. ChangeSetBuilder.no_changes() now returns an explicit Selector.no_selector() (instead of None), and polling persistence is only enabled when the selector is defined—preventing FDv1 fallback payloads (which have no selector) from being written to persistent storage.

Cleans up endpoint constant naming (FDV1_POLLING_ENDPOINT, FDV2_POLLING_ENDPOINT), removes unused RepeatingTask wiring in PollingDataSource, and ensures streaming shuts down immediately when the server indicates revert_to_fdv1.

Includes small store/apply_delta cleanup, docstring typo fixes, and test updates/additions to cover FDv1 payload parsing and the new persistence/selector semantics.

Written by Cursor Bugbot for commit 86a0671. This will update automatically on new commits. Configure here.

@jsonbailey jsonbailey marked this pull request as ready for review February 3, 2026 22:18
@jsonbailey jsonbailey requested a review from a team as a code owner February 3, 2026 22:18
@jsonbailey jsonbailey changed the title chore: Minor cleanup chore: Remove dead code, clarify names, other cleanup Feb 4, 2026
@jsonbailey jsonbailey merged commit f20fffe into main Feb 4, 2026
16 checks passed
@jsonbailey jsonbailey deleted the jb/sdk-1748/minor-changes branch February 4, 2026 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants