fix: Add context manager for clearer, safer locks#396
Merged
jsonbailey merged 6 commits intomainfrom Jan 6, 2026
Merged
Conversation
keelerm84
approved these changes
Jan 6, 2026
kinyoklion
reviewed
Jan 6, 2026
| global __lock | ||
| try: | ||
| __lock.lock() | ||
| c = None |
kinyoklion
approved these changes
Jan 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Introduces context-managed read/write locking and refactors SDK code to use it for clearer, safer concurrency.
ReadWriteLock.read()/write()context managers and updates all locking sites towithblocks (replacing manuallock()/unlock()andrlock()/runlock()) acrossldclient/__init__.py,client.py,feature_store.py, data source/store status providers, FDv2 datasystem (wrapper, store, lifecycle), listeners, flag tracker, andintegrations/test_data*Written by Cursor Bugbot for commit cf0f77a. This will update automatically on new commits. Configure here.