fix: Add warning if relying on Redis max_connections parameter#387
Merged
fix: Add warning if relying on Redis max_connections parameter#387
max_connections parameter#387Conversation
The `new_feature_store` and `new_big_segment_store` methods accept a `max_connections` parameter that has been unused since v8. We cannot start using this parameter now as it would be a functionally breaking change. Instead, we are opting to warn customers who might try setting it explicitly. fixes #386
jsonbailey
approved these changes
Dec 4, 2025
keelerm84
pushed a commit
that referenced
this pull request
Dec 4, 2025
🤖 I have created a release *beep* *boop* --- ## [9.14.0](9.13.1...9.14.0) (2025-12-04) ### Features * adding data system option to create file datasource intializer ([e5b121f](e5b121f)) * adding file data source as an intializer ([#381](#381)) ([3700d1d](3700d1d)) ### Bug Fixes * Add warning if relying on Redis `max_connections` parameter ([#387](#387)) ([e6395fa](e6395fa)), closes [#386](#386) * modified initializer behavior to spec ([064f65c](064f65c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
new_feature_storeandnew_big_segment_storemethods accept amax_connectionsparameter that has been unused since v8.We cannot start using this parameter now as it would be a functionally
breaking change. Instead, we are opting to warn customers who might try
setting it explicitly.
fixes #386
Note
Warns when non-default
max_connectionsis passed to Redis stores, documents it as unused, and adds tests verifying behavior.Redis.new_feature_storeandRedis.new_big_segment_storewhenmax_connectionsdiffers fromRedis.DEFAULT_MAX_CONNECTIONS; advise usingredis_opts={'max_connections': N}.max_connectionsas deprecated/unused.ldclient.logto emit warnings.ldclient/testing/integrations/test_redis.py):max_connectionsarg does not affect Redis connection pool for feature store and big segment store.max_connectionsis non-default and not when default.Written by Cursor Bugbot for commit 4e767c5. This will update automatically on new commits. Configure here.