chore: Flush in memory store on persistent store recovery#372
Merged
chore: Flush in memory store on persistent store recovery#372
Conversation
kinyoklion
reviewed
Nov 17, 2025
| [tool.poetry.group.dev.dependencies] | ||
| mock = ">=2.0.0" | ||
| pytest = ">=2.8" | ||
| pytest = "^8.0.0" |
Member
Author
There was a problem hiding this comment.
It is, but also we were always allowing it to float later. We are actually pinning it behind because it's breaking in older versions now.
kinyoklion
approved these changes
Nov 17, 2025
54cbdff to
c0570e2
Compare
85f59ba to
8e81cdb
Compare
keelerm84
added a commit
that referenced
this pull request
Nov 19, 2025
keelerm84
added a commit
that referenced
this pull request
Nov 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Flushes in-memory data to the persistent store on recovery with stale data, switches client evaluations to use the data system store, tightens polling selector handling, and adds thorough persistence tests.
_persistent_store_outage_recoveryto flush viaStore.commit()whenDataStoreStatus(available=True, stale=True); register listener; set status withDataStoreStatus(available, True)on availability.FEATURES/SEGMENTSviaVersionedDataKind.encodebefore calling persistentinit()._data_system.storefor evaluator sources, initialization checks, andall_flags_state()reads.selectorquery param whenselector.is_defined().Synchronizer.syncreturn type toGenerator["Update", None, None].Written by Cursor Bugbot for commit 8e81cdb. This will update automatically on new commits. Configure here.