chore: Provide selector for use as basis on FDv2 data sources#363
Merged
chore: Provide selector for use as basis on FDv2 data sources#363
Conversation
e55dca5 to
9c3cd49
Compare
b57273e to
bf82505
Compare
kinyoklion
reviewed
Nov 5, 2025
ldclient/impl/datasystem/store.py
Outdated
| items_decoded[key] = kind.decode(item) | ||
| all_decoded[kind] = items_decoded | ||
| try: | ||
| self._lock.rlock() |
Member
There was a problem hiding this comment.
Same question for all the mutations.
Member
Author
There was a problem hiding this comment.
That had been fixed in a previous PR. Just needed rebasing.
bf82505 to
a6b2b3d
Compare
kinyoklion
approved these changes
Nov 5, 2025
keelerm84
added a commit
that referenced
this pull request
Nov 19, 2025
keelerm84
added a commit
that referenced
this pull request
Nov 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Introduces SelectorStore and threads selectors through polling/streaming APIs, FDv2, and tests, including SSE basis query support.
SelectorStoreprotocol and requireselector().Initializer.fetchandSynchronizer.syncsignatures to acceptSelectorStore.PollingDataSource.fetch/sync/_pollto usess.selector()when requesting data.Requester.fetch; no-change/full/changes handling unchanged.SseClientBuilderto take(Config, SelectorStore)and build client with dynamicquery_paramsusing selectorbasis.StreamingDataSource.syncto passSelectorStoreto client builder.SelectorStoreto initializers and synchronizers; consume updates unchanged.fetch(ss),sync(ss),stop()(renamed fromclose).MockSelectorStoreand update all tests to pass aSelectorStore.Written by Cursor Bugbot for commit a6b2b3d. This will update automatically on new commits. Configure here.