fix: custom relationship meta not returned on PaginatedRelatedResourceResponse or PaginatedIdentifierResponse#23
Merged
lindyhopchris merged 1 commit intolaravel-json-api:developfrom Jan 11, 2025
Conversation
…eResponse or PaginatedIdentifierResponse
haddowg
force-pushed
the
fix/relationship-response-meta
branch
from
6e1ce42 to
c3931e5
Compare
lindyhopchris
approved these changes
Jan 11, 2025
Contributor
lindyhopchris
left a comment
lindyhopchris
left a comment
There was a problem hiding this comment.
LGTM, agree adding tests is going to be a big undertaking so need to leave for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug where currently custom meta added to a relationship via withMeta will not be returned on paginated relationship and related endpoints.
Steps to reproduce:
expected result: custom meta in the top level meta object
actual result: only pagination meta and any meta added directly to the response class will be shown.
have not added a test as there are no other response tests and this would be a fairly significant undertaking, perhaps it could be tested via proxy in the integration tests elsewhere?