-
Notifications
You must be signed in to change notification settings - Fork 527
feat: make blob v2 dedicated threshold configurable #5719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make blob v2 dedicated threshold configurable #5719
Conversation
Code ReviewP1 - Thread Safety Issue in Test The test Suggested fix: Either:
The overall implementation approach is reasonable. The threshold is read once at |
Xuanwo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this, I hope this can be a column metadata like blob_dedicated_size_threshold instead.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
OK, got it. |
df3cb95 to
e82609c
Compare
Xuanwo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Others LGTM
|
@Xuanwo I have addressed your comments. |
Xuanwo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this!
No description provided.